Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update hermes config #1064

Merged
merged 2 commits into from
Apr 12, 2024
Merged

feat!: update hermes config #1064

merged 2 commits into from
Apr 12, 2024

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Apr 9, 2024

Closes #1063

Testing

I used this patch locally and got past the error mentioned in the issue but I'm not 100% sure everything is resolved yet b/c my test is failing on something else

@vercel Vercel
Copy link

vercel bot commented Apr 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 2:47pm

@rootulp
Copy link
Contributor Author

rootulp commented Apr 9, 2024

It looks like this was fixed in more recent release branches via #716 but not on v6

@rootulp rootulp marked this pull request as ready for review April 9, 2024 20:57
@rootulp rootulp requested a review from a team as a code owner April 9, 2024 20:57
@rootulp rootulp requested a review from agouin April 9, 2024 20:57
@Reecepbcups
Copy link
Member

Reecepbcups commented Apr 9, 2024 •
edited
Loading

test ci failure:

           	failed to configure relayer r for chain gaia-9: exit code 1:  The Hermes configuration file at path '/home/hermes/.hermes/config.toml' is invalid, reason: parse error: unknown field `event_source`, expected one of `id`, `type`, `rpc_addr`, `websocket_addr`, `grpc_addr`, `rpc_timeout`, `account_prefix`, `key_name`, `key_store_type`, `store_prefix`, `default_gas`, `max_gas`, `gas_adjustment`, `gas_multiplier`, `fee_granter`, `max_msg_num`, `max_tx_size`, `clock_drift`, `max_block_time`, `trusting_period`, `unbonding_period`, `memo_prefix`, `sequential_batch_tx`, `proof_specs`, `trust_threshold`, `gas_price`, `packet_filter`, `address_type`, `extension_options` for key `chains` at line 63 column 1

Assume the hermes docker image version needs to be updated as well for the ictest default

	hermes                  = "hermes"
  defaultContainerImage   = "ghcr.io/informalsystems/hermes"
  DefaultContainerVersion = "v1.7.1"

@Reecepbcups Reecepbcups added the BACKPORT backport into all maintained branches label Apr 9, 2024
@rootulp rootulp marked this pull request as draft April 10, 2024 14:42
@rootulp
Copy link
Contributor Author

rootulp commented Apr 10, 2024 •
edited
Loading

😆

--- FAIL: TestCollector_Stop (0.00s)
    collect_test.go:160: 
        	Error Trace:	/home/runner/work/interchaintest/interchaintest/internal/blockdb/collect_test.go:160
        	Error:      	"6" is not greater than "6"
        	Test:       	TestCollector_Stop

@rootulp rootulp marked this pull request as ready for review April 10, 2024 15:56
@Reecepbcups Reecepbcups merged commit 0ea0168 into strangelove-ventures:v6 Apr 12, 2024
8 checks passed
@Reecepbcups
Copy link
Member

@Mergifyio backport main

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024 •
edited
Loading

backport main

✅ Backports have been created

@Reecepbcups
Copy link
Member

@Mergifyio backport v7

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024 •
edited
Loading

backport v7

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 12, 2024
@rootulp @mergify
feat!: update hermes config (#1064)
af87236 
* feat!: update hermes config

* chore: upgrade to hermes 1.8.2

(cherry picked from commit 0ea0168)

# Conflicts:
#	relayer/hermes/hermes_config.go
#	relayer/hermes/hermes_relayer.go
@mergify mergify bot mentioned this pull request Apr 12, 2024
Merged
mergify bot pushed a commit that referenced this pull request Apr 12, 2024
@rootulp @mergify
feat!: update hermes config (#1064)
68b20d6 
* feat!: update hermes config

* chore: upgrade to hermes 1.8.2

(cherry picked from commit 0ea0168)

# Conflicts:
#	relayer/hermes/hermes_config.go
#	relayer/hermes/hermes_relayer.go
@mergify mergify bot mentioned this pull request Apr 12, 2024
Merged
@rootulp rootulp deleted the rp/hermes-config branch April 12, 2024 18:24
Reecepbcups added a commit that referenced this pull request Apr 23, 2024
@mergify @rootulp @Reecepbcups
feat!: update hermes config (backport #1064) (#1067)
7654c86 
* feat!: update hermes config (#1064)

* feat!: update hermes config

* chore: upgrade to hermes 1.8.2

(cherry picked from commit 0ea0168)

# Conflicts:
#	relayer/hermes/hermes_config.go
#	relayer/hermes/hermes_relayer.go

* fix: conflicts from backport

* add back in CCVConsumerChain

---------

Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Reecepbcups added a commit that referenced this pull request Apr 23, 2024
@mergify @rootulp @Reecepbcups
feat(v7)!: update hermes config (backport #1064) (#1068)
07af56f 
* feat!: update hermes config (#1064)

* feat!: update hermes config

* chore: upgrade to hermes 1.8.2

(cherry picked from commit 0ea0168)

# Conflicts:
#	relayer/hermes/hermes_config.go
#	relayer/hermes/hermes_relayer.go

* fix merge

* add back in CCVConsumerChain & Type

* add TrustedNode

* rm duplicate

---------

Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

@agouin agouin Awaiting requested review from agouin agouin is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees
No one assigned
Labels
BACKPORT backport into all maintained branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rootulp @Reecepbcups