Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Next.js: Upgrade image-size to 2.0" #30770

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 7, 2025

Reverts #30741

Greptile Summary

Reverts Next.js image handling changes by downgrading image-size to v1.0.0 and re-adding sharp as an optional dependency for AVIF image support.

  • Downgraded image-size to v1.0.0 in code/frameworks/nextjs/package.json to maintain compatibility
  • Added sharp@^0.33.3 as optional dependency in both Next.js framework packages
  • Modified code/frameworks/nextjs/src/next-image-loader-stub.ts to handle AVIF images using sharp
  • Downgraded vite-plugin-storybook-nextjs to v1.1.0 in code/frameworks/experimental-nextjs-vite/package.json

@kasperpeulen kasperpeulen added the ci:merged Run the CI jobs that normally run when merged. label Mar 7, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Mar 7, 2025

View your CI Pipeline Execution ↗ for commit ac3fc42.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-07 11:48:41 UTC

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

Generated by 🚫 dangerJS against ac3fc42

@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: ac3fc42, ran on 7 March 2025 at 11:51:24 UTC

The following packages have significant changes to their size or dependencies:

@storybook/experimental-nextjs-vite

Before After Difference
Dependency count 167 177 🚨 +10 🚨
Self size 215 KB 215 KB 🚨 +56 B 🚨
Dependency size 31.38 MB 48.71 MB 🚨 +17.32 MB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 572 581 🚨 +9 🚨
Self size 218 KB 454 KB 🚨 +236 KB 🚨
Dependency size 66.13 MB 82.96 MB 🚨 +16.83 MB 🚨
Bundle Size Analyzer Link Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant