Core: New Status Store #30764
Core: New Status Store #30764
Conversation
…n the state hasn't changed
|
|
View your CI Pipeline Execution ↗ for commit 61e6020.
☁️ Nx Cloud last updated this comment at |
| @@ -101,7 +101,7 @@ const config = defineMain({ | |||
| '@storybook/addon-designs', | |||
| '@storybook/addon-test', | |||
| '@storybook/addon-a11y', | |||
| '@chromatic-com/storybook', | |||
There was a problem hiding this comment.
temporary, until VTA has been updated with the new Status API
| export const componentTestStatusStore = experimental_getStatusStore(STATUS_TYPE_ID_COMPONENT_TEST); | ||
| export const a11yStatusStore = experimental_getStatusStore(STATUS_TYPE_ID_A11Y); |
There was a problem hiding this comment.
Because addon-test both handles CT statuses and a11y statuses, we get a status store slice for each of the two type ids, that operates independently of each other.
| ) | ||
| ); | ||
| })(); | ||
| componentTestStatusStore.set( |
There was a problem hiding this comment.
from an addon's perspective, this change is the main difference between the old and the new API.
| @@ -67,7 +67,10 @@ const bootTestRunner = async (channel: Channel) => { | |||
|
|
|||
| const startChildProcess = () => | |||
| new Promise<void>((resolve, reject) => { | |||
| child = execaNode(vitestModulePath); | |||
| child = execaNode(vitestModulePath, { | |||
| env: { VITEST: 'true', TEST: 'true', NODE_ENV: process.env.NODE_ENV ?? 'test' }, | |||
There was a problem hiding this comment.
these were already set at runtime in the vitest module, but setting them immediately here means that they will be set before anything else.
|
|
||
| const statusStore = createStatusStore({ | ||
| universalStatusStore: | ||
| process.env.VITEST !== 'true' |
There was a problem hiding this comment.
this is a temporary workaround, until we fix UniversalStore leader/follower determination on a holistic level.
| @@ -0,0 +1,595 @@ | |||
| // @vitest-environment happy-dom | |||
There was a problem hiding this comment.
TODO: update these
| const { storyId } = status; | ||
| if (status.typeId !== typeId) { | ||
| // Validate that all statuses have the correct typeId | ||
| throw new Error( |
There was a problem hiding this comment.
TODO: StorybookError?
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>