Fix loading with Node.js v22.12.0 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this package defines `"type": "module"` the contents of `/preset.js` is assumed to be a ESM module, but it contains CJS code. Switching the file type seems to resolve this.
|
@valentinpalkovic would be awesome if we can get this fix released. we are running into the same issue in our project with node 22.12.0, thank you! |
|
Hi @osmestad Thank you for putting together this PR. I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
As this package defines
"type": "module"the contents of/preset.jsis assumed to be a ESM module, but it contains CJS code. Switching the file type seems to resolve this.Issue first reported here: nodejs/node#56127
This revert the commit: 7d3379b I'm not sure what the reasoning was for changing it back then? But with the latest Node release I think this is the way to go. Our build worked fine up to and including the previous Node version:
22.11.0but is broken now.