Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Convert named stories exports value to ObjectExpression #266

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

refactor: Convert named stories exports value to ObjectExpression #266

wants to merge 4 commits into from
+134 −41

Conversation

xeho91
Copy link
Collaborator

@xeho91 xeho91 commented Jan 17, 2025

Resolves #261

@xeho91 xeho91 added enhancement New feature or request patch Increment the patch version when merged internal Changes only affect the internal API labels Jan 17, 2025
@xeho91 xeho91 requested a review from JReinhold January 17, 2025 08:47
@xeho91 xeho91 changed the base branch from main to next January 17, 2025 08:47
@xeho91 xeho91 added the next Related to the next version label Jan 17, 2025
@xeho91
Copy link
Collaborator Author

xeho91 commented Jan 17, 2025 •
edited
Loading

@JReinhold I only need an answer to this question

Technically speaking, it is possible to convert every story attribute to Property (AST node). But for now, I started with tags, because I don't know/remember if converting others would break anything. However, do please let me know if you want me to explore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold Awaiting requested review from JReinhold

Assignees
No one assigned
Labels
enhancement New feature or request internal Changes only affect the internal API next Related to the next version patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Story-level tags are ignored in Vitest integration
1 participant
@xeho91