Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replace ambiguous headers types with actual types #834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/interfaces.ts
Copy link
Contributor Author

@ryami333 ryami333 Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of whitespace/indentation changes because this file had not been correctly formatted with Prettier. See this PR where I set a formatting baseline. Once that is merged I can rebase this PR to make the diffs less noisy.

In the meantime, please hide whitespace changes in code-review.

EDIT: rebased onto main, no more formatting changes.

Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export interface ISbStories<
}
perPage: number
total: number
headers: any
headers: Headers
}

export interface ISbStory<
Expand All @@ -191,7 +191,7 @@ export interface ISbStory<
rels: ISbStoryData[]
story: ISbStoryData<Content>
}
headers: any
headers: Headers
}

export interface IMemoryType extends ISbResult {
Expand Down Expand Up @@ -219,7 +219,7 @@ export interface ISbConfig {
responseInterceptor?: ResponseFn
fetch?: typeof fetch
timeout?: number
headers?: any
headers?: Record<string, string>
region?: string
maxRetries?: number
https?: boolean
Expand Down Expand Up @@ -298,7 +298,7 @@ export interface ISbContentMangmntAPI<

export interface ISbManagmentApiResult {
data: any
headers: any
headers: Headers
}

export interface ISbSchema {
Expand Down
Loading