refactor: Type check and restructure tests #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dang lack of Prettier...
|
@Peeja For some reason after the changes the |
* Make types work * Test through with stubs more and less with mocks * Use `@import` a bunch for readability * Avoid `let`s in favor of `const`s * Separate the rate-limiter middleware's expected environment interface from the general environment, and don't combine them until we actually combine the middlewares into the stack.
Peeja
force-pushed
the
cleaner-promise
branch
from
aa28761
to
c43609c
Compare
fforbeck
approved these changes
Oct 17, 2024
It's the only way to be sure. Co-authored-by: Felipe Forbeck <[email protected]>
Peeja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more what I was getting at with https://github.com/storacha/freeway/pull/116/files#r1787752932. This avoids some of the stashing and mutation by putting more inside the
new Promise()construction itself.I've also pulled
wranglerEnvout into its ownconst, because it's actually an input, not an output. Then I've madeworkerInfoaletwhich is assigned when Wrangler boots, and isundefinedbefore that, signaling that Wrangler is not yet available. The previous code was failing because there wereundefinedfields that aren't typed to allowundefined. Which wasn't an issue until…I also turned type checking on in
test/, because apparently it wasn't already. 😛 And lastly, I've ignored.wrangler, because Wrangler writes to that when it runs.