-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rate limiter + unit tests + readme #115
Merged
Merged
Commits on Jun 13, 2024
-
wip: spike on adding rate limits to freeway
Add a new middleware that checks a rate limiting service and returns a 429 if the CID is over a rate limit. This sketches out an API for the rate limiting and accounting services suggested in storacha/RFC#28 This is not ready to merge, but should probably be the starting point for this work once we all agree that this is the right shape.
Configuration menu - View commit details
-
Copy full SHA for b421208 - Browse repository at this point
Copy the full SHA b421208View commit details
Commits on Sep 18, 2024
-
introduce a KV namespace for caching token metadata - for now the "invalid" boolean is the most important thing, as that's how we decide whether a token is valid. I thought we'd be able to serve tokened requests when in doubt, but I'm a bit worried about people generating random tokens if we go that route - sending a different random token with each request would theoretically allow them to make infinite unbilled requests. instead I went with a pattern that will likely require us to warm the cache before a token-based request achieves hot-storage level performance - we cache auth token metadata in KV and wait for the accounting service to return it if we don't find it in the cache. Using a "Stale While Revalidate" pattern to update the cache will allow us to maintain performance and the ability to disable tokens.
Configuration menu - View commit details
-
Copy full SHA for a4a8bb4 - Browse repository at this point
Copy the full SHA a4a8bb4View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 10d8fe8 - Browse repository at this point
Copy the full SHA 10d8fe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83132c7 - Browse repository at this point
Copy the full SHA 83132c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e61026 - Browse repository at this point
Copy the full SHA 7e61026View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5e9213f - Browse repository at this point
Copy the full SHA 5e9213fView commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3518909 - Browse repository at this point
Copy the full SHA 3518909View commit details -
Configuration menu - View commit details
-
Copy full SHA for e37c45c - Browse repository at this point
Copy the full SHA e37c45cView commit details
Commits on Oct 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 92a981e - Browse repository at this point
Copy the full SHA 92a981eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2805caa - Browse repository at this point
Copy the full SHA 2805caaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a220b6f - Browse repository at this point
Copy the full SHA a220b6fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.