feat!: support for multiple hash types #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
changed the title
|
Awesome, thanks! ❤️ |
olizilla
pushed a commit
that referenced
this pull request
May 1, 2023
🤖 I have created a release *beep* *boop* --- ## [6.0.0](v5.0.0...v6.0.0) (2023-05-01) ### ⚠ BREAKING CHANGES * support for multiple hash types ([#9](#9)) ### Features * add walkUnixfsPath to emit nodes for each path segment ([#7](#7)) ([6c0eed1](6c0eed1)) * getPath with carScope ([#8](#8)) ([a613b45](a613b45)) * support for multiple hash types ([#9](#9)) ([c147fdb](c147fdb)) ### Other Changes * publish from ci ([#13](#13)) ([5df4116](5df4116)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple hash types (like
blake2b, as used by Filecoin).To do this we make use of the "prefix" sent in bitswap wantlist responses. The prefix contains just the metadata of the CID. Instead of assuming the multihash hasher is
sha256, we now inspect the prefix and hash using the specified hasher (if it exists). By default, onlysha256is supported (for smaller bundle), but in the CLI we also addblake2b.Secondarily, this PR fixes a memory leak with many listeners being added to a passed abort controller which were never removed.
Thirdly, this PR moves the static
fromNetworkfactory function from theDagulaclass intop2p.js(as an export). This allows users who are not using bitswap/libp2p (like freeway) to not end up with a massive bundle.