fix: allow to display the code samples when try it panel is hidden #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TryIt`-component is responsible for generating the request data that is used to render the request sample. This requires the component to also be rendered when we don't want to display the TryIt panel itself.
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM! |
|
@weyert Can we also update the docs please |
|
Yeah, I will do. Probably tomorrow. |
|
Totally forgot about it @mnaumanali94 I have added the call out in the documentation now. |
ben-smartbear
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rationale
Previously, the request sample could not be displayed without rendering the TryIt panel, which was a limitation. This change allows the request sample by not visually rendering the TryIt Panel when its opted out off.
Testing
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
CONTRIBUTING.mdOther Available PR Templates:
CONTRIBUTING.md