Allow setting installNamespace in addondeploymentconfig - https://issues.redhat.com/browse/ACM-26912

[tesshuflower]

• VolSync was previously always installed into the volsync-system namespace.
• This allows setting the spec.agentInstallNamespace in the addondeploymentconfig to override the default namespace with another one.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tesshuflower]

/hold

This is put on hold for the moment, and will need to be re-assessed - the epic is going to get moved out to ACM 2.18 - but work from volsync-addon-controller can be updated at some point around 2.18 timeframe.

The main issue currently is that the addondeploymentconfig sets spec.agentinstallnamespace by default to open-cluster-management-agent-addon - which means if we use ths field to set the install namespace, then users who create an addondeploymentconfig for volsync (without even setting the agentInstallNamespace) will get the default of open-cluster-management-agent-addon used.

addon-framework team is still deciding on how to proceed with a way to have the default specified for v1beta1. Once this is figured out we can proceed with this PR.

• Additional issue to keep in mind - if a non-default install namespace is used, if the volsync ManagedClusterAddOn is removed, the current behaviour removes the namespace. This can be a potential issue if the namespace is user-specified, and may contain other workloads outside of VolSync.

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.