-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecc: introduces the vascular proliferation characteristic #9
base: main
Are you sure you want to change the base?
Conversation
1a6e690
to
a7d1316
Compare
5fadca1
to
3915ae1
Compare
kind: binary | ||
description: | ||
"true": | ||
summary: Here is a summary for the 'true' value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be filled out: how will the ECC be assigned, what will the permissible values be, and what do each of the permissible values mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if the "values" should be a feature of the ECC. Having a binary "true/false" seems focused on the ontology itself and not the ECC. It may be useful to have a separate classification or database linking ECCs to their corresponding ontologies.
- "H&E staining" | ||
- qPCR to measure expression levels of angiopoietins and/or VEGF, https://pubmed.ncbi.nlm.nih.gov/10669954/, https://www.nature.com/articles/3780177 | ||
|
||
values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if the "values" should be a feature of the ECC. Having a binary "true/false" seems focused on the ontology itself and not the ECC. It may be useful to have a separate classification or database linking ECCs to their corresponding ontologies.
state: proposed Few things:
|
This pull request adds the Vascular Proliferation ECC
Close #7
Before submitting this PR, please make sure:
CHANGELOG.md
(see"keep a changelog" for more information).