Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecc: introduces the vascular proliferation characteristic #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

madetunj
Copy link

@madetunj madetunj commented Jan 15, 2025

This pull request adds the Vascular Proliferation ECC

Close #7

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added an entry to the CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

@madetunj madetunj self-assigned this Jan 15, 2025
@madetunj madetunj requested a review from claymcleod January 15, 2025 22:02
@madetunj madetunj force-pushed the ecc/vascular-proliferation branch from 1a6e690 to a7d1316 Compare January 15, 2025 22:22
@claymcleod claymcleod requested review from a team and removed request for claymcleod January 15, 2025 22:34
@claymcleod claymcleod added the E-MORPH A morphological characteristic. label Jan 15, 2025
@madetunj madetunj force-pushed the ecc/vascular-proliferation branch from 5fadca1 to 3915ae1 Compare January 17, 2025 19:45
kind: binary
description:
"true":
summary: Here is a summary for the 'true' value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be filled out: how will the ECC be assigned, what will the permissible values be, and what do each of the permissible values mean.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if the "values" should be a feature of the ECC. Having a binary "true/false" seems focused on the ontology itself and not the ECC. It may be useful to have a separate classification or database linking ECCs to their corresponding ontologies.

- "H&E staining"
- qPCR to measure expression levels of angiopoietins and/or VEGF, https://pubmed.ncbi.nlm.nih.gov/10669954/, https://www.nature.com/articles/3780177

values:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if the "values" should be a feature of the ECC. Having a binary "true/false" seems focused on the ontology itself and not the ECC. It may be useful to have a separate classification or database linking ECCs to their corresponding ontologies.

@Ssandor13
Copy link

state: proposed
name: Vascular Proliferation
identifier: ECC-MORPH-000001
rfc: #7
assignment: morphological
description: |
Judah Folkman first discovered the concept of rapid blood vessel growth in 1971, as detailed in his publication in the New England Journal of Medicine (NEJM), referenced here.
His work laid the foundation for further research into angiogenesis, the process of forming new blood vessels.

Few things:

  1. I think we should extend the definition for this ECC. The description is too vague, e.g., "Vascular proliferation refers to the abnormal increase in the number of blood vessels within a tissue, often as a response to hypoxia, tumor growth, or injury. In the context of brain tumors, particularly high-grade gliomas (e.g., glioblastoma, diffuse midline glioma), vascular proliferation is a hallmark feature of aggressive tumor behavior and is associated with rapid growth, resistance to therapy, and poor prognosis."
  2. There are different forms of vascular proliferation and we should consider how to model that here. Increased Microvascular Density (MVD) is a characteristic for this ECC, Endothelial Cell Hyperplasia, Glomeruloid Vascular Proliferation (GVP), etc - I think this is context of what Clay is alluding to in the binary section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-MORPH A morphological characteristic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ECC] Vascular Proliferation
5 participants