Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial commit of wdl-doc documentation page style #262

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

claymcleod
Copy link
Member

This PR adds a basic style scaffold for producing the CSS file used in wdl-doc. Styles can be added in the src folder and compiled into development (pnpm run dev, watches the directory and serves the example.html file live) or production (pnpm run prod, which needs a subsequent pnpm run serve to serve the example.html file).

You can update the example.html file with a fully-featured generated page that we can test with.

  • Please use pnpm, as it's way better than npm in my experience.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

@claymcleod claymcleod requested a review from a-frantz December 5, 2024 17:39
@claymcleod claymcleod self-assigned this Dec 5, 2024
@claymcleod claymcleod changed the title feat: initial commit of wdl-docs style feat: initial commit of wdl-doc documentation page style Dec 5, 2024
Base automatically changed from feat/wdl-doc to main December 10, 2024 22:33
<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><title>read_group_to_string</title><link rel="stylesheet" type="text/css" href="/Users/afrantz/wdl/wdl-doc/theme/dist/styles.css"></head></html><h1>read_group_to_string</h1><h2>Meta</h2><ul><li><b>description:</b> &quot;Stringifies a ReadGroup struct&quot;</li><li><b>outputs:</b> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We should remove the references to your home directory somehow.
  2. It looks like the <html> tag closes before your elements are added in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Already got a WIP addressing that by using a relative path instead (though it complicates things a touch). I noticed that right after I made the WIP commit.
  2. I'll look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants