chore: review feedback

stjude-rust-labs · Jan 15, 2025 · b3a2631 · b3a2631
1 parent c0e446d
commit b3a2631
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/wdl-format/src/token.rs b/wdl-format/src/token.rs
@@ -110,7 +110,7 @@ pub enum TriviaBlankLineSpacingPolicy {
     ///
     /// i.e. a comment, then a blank line, then code, would have the blank
     /// removed.
-    BeforeComments,
+    RemoveTrailingBlanks,
     /// Blank lines are always allowed.
     #[default]
     Always,

diff --git a/wdl-format/src/token/post.rs b/wdl-format/src/token/post.rs
@@ -327,7 +327,7 @@ impl Postprocessor {
                     TriviaBlankLineSpacingPolicy::Always => {
                         self.blank_line(stream);
                     }
-                    TriviaBlankLineSpacingPolicy::BeforeComments => {
+                    TriviaBlankLineSpacingPolicy::RemoveTrailingBlanks => {
                         if matches!(next, Some(&PreToken::Trivia(Trivia::Comment(_)))) {
                             self.blank_line(stream);
                         }

diff --git a/wdl-format/src/token/pre.rs b/wdl-format/src/token/pre.rs
@@ -131,17 +131,18 @@ impl TokenStream<PreToken> {
         self.0.push(PreToken::IndentEnd);
     }
 
-    /// Inserts a blank lines allowed context change.
+    /// Inserts a trivial blank lines "always allowed" context change.
     pub fn blank_lines_allowed(&mut self) {
         self.0.push(PreToken::LineSpacingPolicy(
             TriviaBlankLineSpacingPolicy::Always,
         ));
     }
 
-    /// Inserts a blank lines allowed before comments context change.
+    /// Inserts a trivial blank lines "not allowed after comments" context
+    /// change.
     pub fn blank_lines_allowed_between_comments(&mut self) {
         self.0.push(PreToken::LineSpacingPolicy(
-            TriviaBlankLineSpacingPolicy::BeforeComments,
+            TriviaBlankLineSpacingPolicy::RemoveTrailingBlanks,
         ));
     }