Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nokogiri-html5-inference to properly support HTML fragment parsing #696

Merged
merged 8 commits into from
May 5, 2024
Merged

Implement nokogiri-html5-inference to properly support HTML fragment parsing #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a1a5027
Add first batch of tests
marcoroth Apr 24, 2024
bbb0868
Add test for Alpine.js-like attributes
marcoroth Apr 24, 2024
e6e8b73
Implement `nokogiri-html5-inference`
marcoroth Apr 24, 2024
441d68a
Update tests
marcoroth Apr 26, 2024
6d8cefc
Standard
marcoroth Apr 26, 2024
b49b864
Bump `nokogiri-html5-inference` to `0.2.0`
marcoroth Apr 26, 2024
b62269d
Update `nokogiri-html5-inference` to latest PR branch
marcoroth May 2, 2024
f4ae1ba
Bump `nokogiri-html5-inference` to `0.3.0`
marcoroth May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ PATH
activesupport (>= 5.2, < 8)
cable_ready (~> 5.0)
nokogiri (~> 1.0)
nokogiri-html5-inference (~> 0.3)
rack (>= 2, < 4)
railties (>= 5.2, < 8)
redis (>= 4.0, < 6.0)
Expand Down Expand Up @@ -127,6 +128,8 @@ GEM
racc (~> 1.4)
nokogiri (1.16.2-x86_64-linux)
racc (~> 1.4)
nokogiri-html5-inference (0.3.0)
nokogiri (~> 1.14)
parallel (1.22.1)
parser (3.2.1.0)
ast (~> 2.4.1)
Expand Down
1 change: 1 addition & 0 deletions lib/stimulus_reflex.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
require "action_cable"
require "action_view"
require "nokogiri"
require "nokogiri/html5/inference"
require "cable_ready"
require "stimulus_reflex/version"
require "stimulus_reflex/open_struct_fix"
Expand Down
8 changes: 5 additions & 3 deletions lib/stimulus_reflex/html/document_fragment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
# frozen_string_literal: true

# forzen_string_literal: true

module StimulusReflex
module HTML
class DocumentFragment < Document
def parsing_class
Nokogiri
Nokogiri::HTML5::Inference
end

def document_element
@document
end
end
end
Expand Down
1 change: 1 addition & 0 deletions stimulus_reflex.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Gem::Specification.new do |gem|
gem.add_dependency "nokogiri", "~> 1.0"
gem.add_dependency "rack", ">= 2", "< 4"
gem.add_dependency "redis", ">= 4.0", "< 6.0"
gem.add_dependency "nokogiri-html5-inference", "~> 0.3"

gem.add_development_dependency "bundler", "~> 2.0"
gem.add_development_dependency "magic_frozen_string_literal", "~> 1.2"
Expand Down
4 changes: 1 addition & 3 deletions test/broadcasters/selector_broadcaster_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@ class SelectorBroadcasterTest < StimulusReflex::BroadcasterTestCase
"operations" => [
{
"selector" => "html",
# Nokogiri automatically adds a `<meta>` tag for the encoding
# See. https://github.com/sparklemotion/nokogiri/blob/6ea1449926ce97648bb2f7401c9e4fdcb0e261ba/lib/nokogiri/html4/document.rb#L34-L35
"html" => "<head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"><title>Test</title></head><body><div><div>bar</div><div>baz</div></div></body>",
"html" => "<head><title>Test</title></head><body><div><div>bar</div><div>baz</div></div></body>",
"payload" => {},
"childrenOnly" => true,
"permanentAttributeName" => nil,
Expand Down
Loading
Loading