Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to debian:buster-slim #143

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Upgrade to debian:buster-slim #143

merged 1 commit into from
Aug 17, 2020

Conversation

EthraZa
Copy link
Contributor

@EthraZa EthraZa commented Aug 17, 2020

Upgrade to Debian 10 Slim.

  • Add libmariadb3 to build pure-ftpd-mysql_*.deb.
  • Add perl dependency. (Really?)
  • Add other pure-ftpd compiled deb files to Dockerfile commented out just to help people wanting to build image with DB support

Fix to #142
Maybe help #130

@EthraZa
Copy link
Contributor Author

EthraZa commented Aug 17, 2020

The second commit adds the https://github.com/naitso/ftpUserManager shell script that may help people administrate pure-ftpd virtual users as in #140

@stilliard
Copy link
Owner

Hey @EthraZa
This looks great!
My only issue with the ftpUserManager script is it doesn't have a licence, without one we can't package it with our container sorry.

@EthraZa
Copy link
Contributor Author

EthraZa commented Aug 17, 2020

That's true. Didn't noticed the lack of license. But can you merge just c804f28 or do I need to do some modification?

@EthraZa
Copy link
Contributor Author

EthraZa commented Aug 17, 2020

About ftpUserManager I'm thinking in build an inspired script that uses shell2http anyways.

@stilliard
Copy link
Owner

@EthraZa sure best to open a new PR for a new script to be included, if you remove that other commit and force push (ref https://stackoverflow.com/a/51400593) I can test & merge the first one as it looks great thanks :)

@EthraZa
Copy link
Contributor Author

EthraZa commented Aug 17, 2020

Done

@stilliard stilliard merged commit dc3c9fe into stilliard:master Aug 17, 2020
@stilliard
Copy link
Owner

Thanks @EthraZa ! Awesome work on this 👍

@stilliard
Copy link
Owner

Docker hub is currently building the new latest tag & a new "buster-latest" tag for this.
Once that's done I'll upgrade the hardened branch/tag as well.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants