Polishing

stfndamjanovic · Jan 24, 2024 · 5cdc6f4 · 5cdc6f4
1 parent 5e5778b
commit 5cdc6f4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/Storage/CircuitBreakerStorage.php b/src/Storage/CircuitBreakerStorage.php
@@ -4,7 +4,6 @@
 
 use Stfn\CircuitBreaker\CircuitBreaker;
 use Stfn\CircuitBreaker\CircuitState;
-use Stfn\CircuitBreaker\Counter;
 
 abstract class CircuitBreakerStorage
 {

diff --git a/src/Storage/RedisStorage.php b/src/Storage/RedisStorage.php
@@ -4,7 +4,6 @@
 
 use Stfn\CircuitBreaker\CircuitBreaker;
 use Stfn\CircuitBreaker\CircuitState;
-use Stfn\CircuitBreaker\Counter;
 
 class RedisStorage extends CircuitBreakerStorage
 {
@@ -19,9 +18,8 @@ class RedisStorage extends CircuitBreakerStorage
     protected \Redis $redis;
 
     /**
-     * @param string $service
      * @param \Redis $redis
-     * @throws \RedisException
+     * @throws \Exception
      */
     public function __construct(\Redis $redis)
     {
@@ -33,7 +31,7 @@ public function __construct(\Redis $redis)
     }
 
     /**
-     * @param string $service
+     * @param CircuitBreaker $breaker
      * @return void
      * @throws \RedisException
      */
@@ -99,7 +97,6 @@ protected function incrementOrCreate($key, $ttl)
     public function resetCounter(): void
     {
         $this->redis->del($this->getNamespace(self::FAIL_COUNT_KEY));
-        $this->redis->del($this->getNamespace(self::SUCCESS_COUNT_KEY));
     }
 
     /**

diff --git a/tests/CircuitBreakerTest.php b/tests/CircuitBreakerTest.php
@@ -47,7 +47,7 @@ public function test_if_it_will_record_every_failure()
     {
         $breaker = CircuitBreaker::for('test-service')
             ->withOptions([
-                'failure_threshold' => 4
+                'failure_threshold' => 4,
             ]);
 
         $fail = function () {
@@ -71,7 +71,7 @@ public function test_if_it_will_open_circuit_when_failure_threshold_is_reached()
     {
         $breaker = CircuitBreaker::for('test-service')
             ->withOptions([
-                'failure_threshold' => 3
+                'failure_threshold' => 3,
             ]);
 
         $fail = function () {
@@ -201,7 +201,7 @@ public function test_if_it_can_fail_even_without_exception()
     {
         $breaker = CircuitBreaker::for('test-service')
             ->withOptions([
-                'failure_threshold' => 3
+                'failure_threshold' => 3,
             ])
             ->failWhen(function ($result) {
                 return $result instanceof \stdClass;