Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update append_from function signature #232

Merged

Conversation

anish-mudaraddi
Copy link
Collaborator

@anish-mudaraddi anish-mudaraddi commented Jun 27, 2024

previously append_from would work like this:

query.append_from("project", cloud_account="prod", "project_id", "project_name")

now it works like this

query.append_from("project", cloud_account="prod", props=["project_id", "project_name"])

which is more intuitive and fits python conventions

should take a list of props instead of *args - it's more intuitive and cleaner
update to use new function signature
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (943f21d) to head (a988bc7).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         187      187           
  Lines        8258     8258           
  Branches      519      519           
=======================================
  Hits         8097     8097           
  Misses        135      135           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khalford khalford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khalford khalford merged commit eb65e6b into stfc:main Aug 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants