Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualisation #12

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Visualisation #12

wants to merge 7 commits into from

Conversation

Cbameron12
Copy link
Collaborator

No description provided.

struct=struct_path, **request.model_dump(exclude={"struct"})
)

results_file_path = results.pop("results_path", None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pop?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to send that information to the frontend but wanted to use it in the API

logger.info(f"Hash matches: {calculate_md5_checksum(file_content, file_hash)}")

# Disabled hash check for now
# logger.info(f"Hash matches: {calculate_md5_checksum(file_content,file_hash)}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not used anymore? Any reason to keep it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in case it was desired later on, I left the method for checking the hash in comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants