-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
102 add md calcjob #104
102 add md calcjob #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of interest, are you able to run --help
or something to list the options, and if so, if that affected by inheritance between the calculations, or is that side of things handled separately?
To clarify this a bit better, a few examples of shared arguments for typer are discussed here. With janus, for example, if I defined the shared Clearly the CLI is built quite differently with click, classes, etc. here, but I can imagine an issue that looks similar could occur - the help may not include inherited options. It's probably fine, but it's something to check. |
Some things to do still
But feel free to start commenting on the code as these thing won't modify (I think) what I've done so far |
Just a note that there will be minor changes to the janus CLI once stfc/janus-core#100 is merged to allow reading a config. The currently linked janus-core will be fine, but if we updated that before merging this, we'd need to take it into account. In most cases I changed the Python variables to match the CLI option names, so the CLI is largely unchanged, but there is at least one difference: |
Co-authored-by: ElliottKasoar <[email protected]>
Co-authored-by: ElliottKasoar <[email protected]>
Co-authored-by: ElliottKasoar <[email protected]>
Co-authored-by: ElliottKasoar <[email protected]>
Co-authored-by: ElliottKasoar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion, but otherwise I think this looks good.
We'll revisit a lot of the option names, config etc. anyway at some point.
aa43e0b
Co-authored-by: ElliottKasoar <[email protected]>
328ead9
Co-authored-by: ElliottKasoar <[email protected]>
Co-authored-by: ElliottKasoar <[email protected]>
No description provided.