Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for multi-sprite Goals and BeeBots #51

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

gregcorbett
Copy link
Collaborator

  • all Components now take a list of sprites/images rather than a single
    sprite/image.
    sprites in future scenarios.
  • this is backwards compatiable with all 1.X scenarios
  • update test cases to use lists for Component sprites
  • Add complete method to Goal that completes goal
    • so that it can handle the sprite change
    • rework has_been_met to is_complete, as complete() is
      a better method name than met() for this method.
    • update test cases due to Goal changes and update comments

- all Components now take a list of sprites/images rather than a single
  sprite/image.
  sprites in future scenarios.
- this is backwards compatiable with all 1.X scenarios
- update test cases to use lists for Component sprites
- Add complete method to Goal that completes goal
  - so that it can handle the sprite change
  - rework has_been_met to is_complete, as complete() is
    a better method name than met() for this method.
  - update test cases due to Goal changes and update comments
@gregcorbett gregcorbett force-pushed the multi_sprite_components branch from 517f009 to 12fcaf9 Compare July 12, 2019 19:38
@gregcorbett
Copy link
Collaborator Author

codeclimate issues have been captured in #52 and #53.

@gregcorbett gregcorbett marked this pull request as ready for review July 12, 2019 20:08
@gregcorbett gregcorbett merged commit 2b41ece into stfc:develop Jul 12, 2019
@gregcorbett gregcorbett deleted the multi_sprite_components branch July 12, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant