ENH - rewrite rally_extract_tests.py #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalford
requested changes
Jun 6, 2024
Comment on lines
+171
to
+173
| assert all( | ||
| val in config_dict for val in required_values | ||
| ), "Config file is missing required values." |
There was a problem hiding this comment.
Do we want to error with which values we are missing here?
meoflynn
requested changes
Jun 17, 2024
| response.raise_for_status() | ||
|
|
||
|
|
||
| def main(user_args: List): |
There was a problem hiding this comment.
Could you add docstrings to the main method?
Would this method return a specific variable?
There was a problem hiding this comment.
no it doesn't return anything - it just writes rally test results to a file
Co-authored-by: Kalibh Halford <[email protected]>
|
I'm still waiting for when Ops is not busy so I can grab some dummy rally output files to use for testing |
|
I'm closing this until I write the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrite rally_extract_tests.py incorporating changes from #89
Needs unit-tests and proper testing