(closes #1796) Refactor LFRic builtins tests

[sergisiso]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (29bba60) to head (f69f3ee).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2640   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         352      352           
  Lines       48509    48509           
=======================================
  Hits        48444    48444           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sergisiso]

This is ready for review, this PR adds metadata checks to the LFRic builtin tests (which I think were missing) and removes invoke generation checks (which I think are unneeded since its not responsibility of these classes). One for @arporter or @TeranIvy

[arporter]

Looks good Sergi. I won't check the integration tests this time around as the only changed code is in the tests. Main request is to add compilation testing where possible to the modified tests.
No need to update docs or tutorials.

[sergisiso]

@arporter This is ready for another look, CI-permiting. In addition to your comments, I also noticed there was a separate test file for integer builtins. Since this are empty classes, I thought it was simpler to test them in combination with their parent, and instead of testing the lowering (which they don't alter), I check the metadata, which is the important differing part, and its string (see last commit).

[arporter]

All requested changes have been made (or refuted). Good to actually reduce the size of the repo rather than increase it :-)
Integration tests are running currently.

[arporter]

Integration tests were green.