This repository was archived by the owner on Dec 16, 2018. It is now read-only.
Adding support for CI 3 and SyslogUDPHandler for external log systems like papertrail#6
Open
cumanzorx07 wants to merge 3 commits intostevethomas:masterfrom
Open
Adding support for CI 3 and SyslogUDPHandler for external log systems like papertrail#6cumanzorx07 wants to merge 3 commits intostevethomas:masterfrom
cumanzorx07 wants to merge 3 commits intostevethomas:masterfrom
Conversation
cumanzorx07
commented
Dec 4, 2017
- Changes /libraries/Log.php to /core/MY_Log.php for CI 3 compatibility
- Add SyslogUDPHandler in order to support External UDP log receivers like papertrail
stevethomas
suggested changes
Dec 4, 2017
Owner
There was a problem hiding this comment.
Thanks for the PR @cumanzorx07
-
Can you remove the .idea files? They should not be versioned.
-
You have fixed the monolog version in composer, there is no reason to not allow updates within the 1.x.x branch.
-
I don't work with CodeIgniter much anymore, are you sure this still works with 2.0 as well? It may be better to push to a new version 3 branch instead.
Author
|
Hi @stevethomas , here are my answers to each question.
Let me do the adjustments and I will let you know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.