-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scss #1142
Open
nguyenhaiphan
wants to merge
53
commits into
stevenwanderski:development
Choose a base branch
from
nguyenhaiphan:development
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add scss #1142
nguyenhaiphan
wants to merge
53
commits into
stevenwanderski:development
from
nguyenhaiphan:development
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing readme step3
Put HTTPS in the script source for added security (and as is officially recommended by Google on their Hosted Libraries page). Also, update the jQuery version to the latest and most recent version of jQuery 1.x hosted by Google's Hosted Libraries CDN.
Specify HTTPS and update jQuery library version in ready
fix index issue - forbids going to undefined index | closes stevenwanderski#835
Remove private flag from package.json
translateZ property is camel-cased: http://www.w3.org/TR/css3-transforms/#identity-transform-function
As documented on the NPM documentation (https://docs.npmjs.com/files/package.json#license). The license field has to comply with the SPDX specification for communicating the licenses and copyrights associated with a software package. This commit changes the license to a valid SPDX value (MIT)
I am trying to install this package with `yarn` using node 4 LTS. `yarn` will not install this package before of this engine restriction. Is this restriction rally necessary?
jQuery 3 compatibility
…move-margin-center Removes auto center from theme - v4.2.8
Allow using newer node engines.
…uto-centering Removes auto-centering when no pager or controls - v4.2.11
Last week, Github implemented a strict standard for .md files. As a result, this document was adversely affected. Went in and fixed the formatting. For more information on Github's change: https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown
Cleanup and fix formatting issues.
Format the license in package.json to match the SPDX standard
…nter Fix stevenwanderski#881 Problem with getPagerQty
…ith_compressors Fix compatibility with compressors (YUI Compressor)
Update jquery.bxslider.css
Ensure that `slider.working` is set to false at the end of `goToSlide()`, regardless of what happened with `position`.
Fix division by 0
@nguyenhaiphan Can you rebase this properly so it doesn't have 50 unrelated commits in it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert css to scss one. with variable for path