iverilog: Allow tool path to have spaces in it #1190
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsclausen
force-pushed
the
tool-path-spaces
branch
25 times, most recently
from
ca6661d to
b4f6b11
Compare
Newer version of the linker on MacOS provide a deprecation warning when using the `-undefined` flag with the `suppress` value. This is cause CI to fail to do logs not matching when building VPI modules. Switch to using the `dynamic_lookup` value for the flag instead, which resolves the warning and is the behavior we want when loading the module. Signed-off-by: Lars-Peter Clausen <[email protected]>
larsclausen
force-pushed
the
tool-path-spaces
branch
3 times, most recently
from
aa7dd0a to
0794189
Compare
When invoking the various subcommands make sure the path to the executable is quoted. This allows it to contain spaces. Signed-off-by: Lars-Peter Clausen <[email protected]>
larsclausen
force-pushed
the
tool-path-spaces
branch
from
0794189 to
a1ac28d
Compare
|
Is this ready to be integrated? I noticed it solves one of the open issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking the various subcommands make sure the path to the executable is quoted. This allows it to contain spaces.
Resolves #1187