Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for toggling of gitignored files #451

Closed
wants to merge 1 commit into from

Conversation

fmgornick
Copy link

Hi! i'm a big fan of this plugin and thought this feature would be a nice addition, so i figured it'd be a good opportunity to try and contribute!

I saw there was a recipe provided for hiding gitignored files in an oil buffer and found that it was almost what i wanted. I personally prefer seeing them by default, but then toggling them off when they get in the way, so i thought it'd be nice if there was a toggle option similar to how toggle_hidden() works.

this change adds the ability to toggle on and off gitignored files with the default keymap gI (this command does nothing if not in a git repo btw). I'm not partial to gI or anything tho, so if you have a better idea for a default keymap i can always change it!

I also updated the docs accordingly and removed the aforementioned recipe since it's now a config option. I totally understand if this change seems too invasive, so no hard feelings if you wanna close it out!

@github-actions github-actions bot requested a review from stevearc July 19, 2024 22:12
@stevearc
Copy link
Owner

I think I'd prefer to keep this as a recipe that lives in the user config. I'd like the built-in logic to be pretty simple so it's easy to reason about adding customizations on top of it

@stevearc stevearc closed this Jul 23, 2024
@fmgornick
Copy link
Author

makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants