feat: add support for mini.icons
#439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds explicit support for
mini.iconsfor providing icons to oil. This generalizes the icon providing into a function that figures out which icon provider is available (preferringmini.iconsovernvim-web-devicons) and returning a common icon providing interface.mini.iconsalso has the ability to provide directory icons so this allows the icon provider to provide any type of icon and it's up to the provider to figure out how to handle what it can.I tested it with each plugin individually as well as both and neither. It is working great! Let me know what you think of the implementation or if you have any recommendations to refactor this. I tried to match the code style and conventions in the codebase.
Thanks so much for such a great project!