Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: icon column highlight #366

Merged
merged 2 commits into from
May 6, 2024
Merged

fix: icon column highlight #366

merged 2 commits into from
May 6, 2024

Conversation

man0xff
Copy link
Contributor

@man0xff man0xff commented May 1, 2024

There is a 'highlight' property in the docs for icon column but it doesn't work. So here is a fix.

@github-actions github-actions bot requested a review from stevearc May 1, 2024 10:24
@stevearc
Copy link
Owner

stevearc commented May 6, 2024

Thanks for the PR! Made some tweaks to support highlight as a function as well as a string.

@stevearc stevearc merged commit 752563c into stevearc:master May 6, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevearc stevearc Awaiting requested review from stevearc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@man0xff @stevearc