fix: previewing and editing files on windows #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
force-pushed
the
stevearc-replace-edit
branch
from
1c884f1 to
fa078a0
Compare
This was referenced Nov 4, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #204
There are a lot of problems with special characters and
:editon Windows. neovim/neovim#3912 and vim/vim#541I think that with the current utilities, there is literally no way to make
:editbehave properly in all cases. As an example, on Windows::edit fname$PATH.txtwill expand the$PATHvariable, leading to a garbage filename:edit fname\$PATH.txtwill treat the\as a path separator, causingfnameto be a directory and$PATH.txtthe file within it.I'm trying to work around this issue entirely by using
bufaddto load the file path directly as a buffer, then using the:buffercommand to switch to it. Preliminary results look good, but it needs more testing because I'm not at all confident that:bufferwill run all the same autocmds and have all the same side effects as:edit.