feat: grpc-web support promise stream #631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Stewart <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
"responsePromiseOrObservable" was changed to return the Observable type if clientStreaming is set: stephenh@d3e7f1f#r79607248 This is only the case when using grpc-web. Fixes stephenh#628 Signed-off-by: Christian Stewart <[email protected]>
paralin
requested changes
Jul 28, 2022
| const inputType = requestType(ctx, methodDesc, partialInput); | ||
| params.push(code`request: ${inputType}`); | ||
| // grpc-web client stream or bidirectional stream not request params when use Promise. | ||
| if (!options.returnObservable && options.outputClientImpl === 'grpc-web' && methodDesc.clientStreaming) { |
There was a problem hiding this comment.
Just invert the if statement here.
if (options.returnObservable || options.outputClientImpl !== "grpc-web" || !methodDesc.clientStreaming)
There was a problem hiding this comment.
"grpc-web client stream or bidirectional stream not request params when use Promise."
I can't understand this sentence, could you make it more clear?
There was a problem hiding this comment.
When using the Promise return type, the input parameter does not require the request parameter.
In this implementation, the request parameter is not required. Use callback to get the relevant data stream, use the write method to send data streams.
|
@luhuaei Are you still working on this? Am happy to help with getting it ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.