fix: grpc-web issue#239 where client streaming was producing incorr…

integration/grpc-web-client-streaming/client-ts.ts

@@ -0,0 +1,45 @@
+#!/usr/bin/env node
+
+import { NodeHttpTransport } from '@improbable-eng/grpc-web-node-http-transport';
+import { DashAPICredsClientImpl, DashStateClientImpl, GrpcWebImpl } from './example';
+import { grpc } from '@improbable-eng/grpc-web';
+
+const rpc = new GrpcWebImpl('http://localhost:9090', {
+  transport: NodeHttpTransport(),
+  debug: false,
+  metadata: new grpc.Metadata({ SomeHeader: 'bar' }),
+});
+
+const client = new DashStateClientImpl(rpc);
+const creds = new DashAPICredsClientImpl(rpc);
+
+async function main() {
+  console.log('calling client.UserSettings');
+  console.log(await client.UserSettings({}));
+
+  console.log('calling creds.Create');
+  const cred = await creds.Create({ description: 'test desc fooo' });
+  console.log(cred);
+
+  console.log('calling creds.Delete');
+  const del = await creds.Delete({ id: cred.id });
+  console.log(del);
+
+  console.log('calling creds.Update');
+  try {
+    await creds.Update({ description: 'test desc2' });
+  } catch (e) {
+    console.log('got expected error', e.message);
+  }
+
+  const obs = client.ActiveUserSettingsStream({});
+  await obs.forEach((value) => {
+    console.log('Got', value);
+    client.ChangeUserSettingsStream({ id: String(Math.random()) });
+  });
+}
+
+main().then(
+  () => console.log('done'),
+  (err) => console.log('failed', err)
+);

integration/grpc-web-client-streaming/example-test.ts

@@ -0,0 +1,23 @@
+import { DashStateClientImpl } from './example';
+
+describe('grpc-web', () => {
+  it('at least compiles', () => {
+    // TODO move the hand-run `client-ts` integration into here, but for now
+    // at least check that things compile
+    const rpc = {
+      unary: jest.fn(),
+      invoke: jest.fn(),
+    };
+    const client = new DashStateClientImpl(rpc);
+    client.UserSettings({});
+  });
+  it('binds rpc function', () => {
+    const rpc = {
+      unary: jest.fn(),
+      invoke: jest.fn(),
+    };
+    const client = new DashStateClientImpl(rpc);
+    const userSettings = client.UserSettings;
+    userSettings({});
+  })
+});

integration/grpc-web-client-streaming/example.proto

@@ -0,0 +1,72 @@
+syntax = "proto3";
+
+package rpx;
+
+service DashState {
+  rpc UserSettings(Empty) returns (DashUserSettingsState);
+  rpc ActiveUserSettingsStream(Empty) returns (stream DashUserSettingsState);
+  rpc ChangeUserSettingsStream (stream Cred) returns (stream DashUserSettingsState) {}
+}
+
+message DashFlash {
+  string msg = 1;
+  Type type = 2;
+
+  enum Type {
+    Undefined = 0;
+    Success = 1;
+    Warn = 2;
+    Error = 3;
+  }
+}
+
+message DashUserSettingsState {
+  string email = 1;
+  URLs urls = 6;
+  repeated DashFlash flashes = 7;
+
+  message URLs {
+    string connect_google = 1;
+    string connect_github = 2;
+  }
+}
+
+
+//----------------------
+// API Creds
+//----------------------
+service DashAPICreds {
+  rpc Create(DashAPICredsCreateReq) returns (DashCred);
+  rpc Update(DashAPICredsUpdateReq) returns (DashCred);
+  rpc Delete(DashAPICredsDeleteReq) returns (DashCred);
+}
+
+message Cred {
+  string id = 7;
+}
+
+message DashCred {
+  string description = 2;
+  string metadata = 3;
+  string token = 4;
+  string id = 7;
+}
+
+message DashAPICredsCreateReq {
+  string description = 1;
+  string metadata = 2;
+}
+
+message DashAPICredsUpdateReq {
+  string cred_sid = 1;
+  string description = 2;
+  string metadata = 3;
+  string id = 5;
+}
+
+message DashAPICredsDeleteReq {
+  string cred_sid = 1;
+  string id = 3;
+}
+
+message Empty {}