Update Name serialization to use JSON string #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the code to serialize instances of `Name` directly to a string instead of an array of characters. * Modify `encodeName` function in `src/Morphir/IR/Name/Codec.elm` to serialize `Name` to a JSON string. * Modify `decodeName` function in `src/Morphir/IR/Name/Codec.elm` to deserialize a JSON string to a `Name`. * Update references to `Name` serialization in `src/Morphir/JsonSchema/Backend.elm` to use the updated string serialization. * Update references to `Name` serialization in `src/Morphir/JsonSchema/Backend/Codec.elm` to use the updated string serialization. * Add tests in `tests/Morphir/IR/NameTests.elm` to verify `Name` serialization to a JSON string. * Add tests in `tests/Morphir/IR/NameTests.elm` to verify `Name` deserialization from a JSON string. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/stephengoldbaum/morphir-elm?shareId=XXXX-XXXX-XXXX-XXXX).
…ist of strings * **`src/Morphir/IR/Name.elm`** - Change `Name` type definition to `String` - Modify `fromString` function to return the input string directly - Update `toTitleCase`, `toCamelCase`, `toSnakeCase`, `toHumanWords`, and `toHumanWordsTitle` functions to work with the new `Name` type as a `String` * **`src/Morphir/IR/Name/Codec.elm`** - Update `encodeName` function to serialize `Name` to a JSON string - Update `decodeName` function to deserialize a JSON string to a `Name` * **`src/Morphir/IR/Name/CodecV1.elm`** - Update `encodeName` function to serialize `Name` to a JSON string - Update `decodeName` function to deserialize a JSON string to a `Name` * **`src/Morphir/IR/FQName.elm`** - Add `empty` function to return an empty `FQName` using the new `Name` structure - Replace all occurrences of `( [ [] ], [], [] )` with `FQName.empty` * **`tests/Morphir/IR/NameTests.elm`** - Update tests to verify `Name` serialization to a JSON string - Update tests to verify `Name` deserialization from a JSON string - Modify tests for `fromString`, `toTitleCase`, `toCamelCase`, `toSnakeCase`, `toHumanWords`, and `toHumanWordsTitle` functions to work with the new `Name` type as a `String`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code to serialize instances of
Namedirectly to a string instead of an array of characters.encodeNamefunction insrc/Morphir/IR/Name/Codec.elmto serializeNameto a JSON string.decodeNamefunction insrc/Morphir/IR/Name/Codec.elmto deserialize a JSON string to aName.Nameserialization insrc/Morphir/JsonSchema/Backend.elmto use the updated string serialization.Nameserialization insrc/Morphir/JsonSchema/Backend/Codec.elmto use the updated string serialization.tests/Morphir/IR/NameTests.elmto verifyNameserialization to a JSON string.tests/Morphir/IR/NameTests.elmto verifyNamedeserialization from a JSON string.For more details, open the Copilot Workspace session.