Some fixes and improvements #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p to debug specific chrome installations)
…eatance and message responses losing)
Co-authored-by: Stephan Lensky <[email protected]>
|
👋 Hey @yoori, the code to fix websockets 14.0 needed a bit more work, so I thought it was fastest to just fix myself. Your PR was helpful for this, so I gave you credit here. Thank you! I know there are also some other changes in this PR that I would still be happy to merge. Please feel free to rebase off of latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope, that now we have place to collect fixes for nodriver.
I'm trying to stabilize it for flare-bypasser and am debug now an intermittent issue with CDP replies being lost - case when some call can be timeouted (navigate, screenshot), but internally looks like listening loop don't see answer for CDP command, but recv it when we start browser closing (by timeout = 60) ...
Here few fixes and improvements, that I need, and I think - they are useful for the project:
cookie parsing fix (CookieJar.get_all don't work for chrome >=129)
websockets 14.0 adaptation
don't use
__count__for CDP message id generation (it is strange) and never drop it to zero - I'm putting this part in order to prevent the loss of answers due to repetitions of CDP message id.some little changes