I cannot have calculate_for_pca_dimensions bigger than top

stemangiola · Oct 28, 2023 · 67b61d5 · 67b61d5
1 parent 749ce37
commit 67b61d5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/functions.R b/R/functions.R
@@ -2259,7 +2259,7 @@ get_reduced_dimensions_UMAP_bulk <-
            of_samples = TRUE,
            transform = log1p,
            scale = TRUE,
-           calculate_for_pca_dimensions = 20,
+           calculate_for_pca_dimensions = min(20, top),
            ...) {
 
     if(!is.null(calculate_for_pca_dimensions) & (

diff --git a/R/functions_SE.R b/R/functions_SE.R
@@ -419,7 +419,7 @@ get_reduced_dimensions_UMAP_bulk_SE <-
            of_samples = TRUE,
            transform = log1p,
            scale = NULL, # This is only a dummy argument for making it compatibble with PCA
-           calculate_for_pca_dimensions = 20,
+           calculate_for_pca_dimensions = min(20, top),
            ...) {
     # Comply with CRAN NOTES
     . = NULL