SLR - SL-142 #82
Merged
SLR - SL-142 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a further filter to control the connection URL text by not only hook prefix, that will be unique per plugin, but by slug (unique by feature in the context of a plugin) as well.
dpanta94
requested changes
Sep 4, 2024
| if ( $this->resource->is_using_oauth() ) { | ||
| ob_start(); | ||
|
|
||
| if ( $this->resource->oauth_requires_license_key() ) { | ||
| echo $this->view->render( self::VIEW, $args ); |
There was a problem hiding this comment.
I would somehow like to apply_filters( 'stellarwp/uplink/' . Config::get_hook_prefix() . '/license_field_html', ... to this as well. From an external developer's perspective utilizing the filter should modify the html regardless if the license field is printed as part of the oauth or not.
dpanta94
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code, where required, to support the customization features required by SLR in the SL-142 ticket.