WIP - Refactor to cater for falsey get_plugin() return value #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollback license field changes. Check for falsey rather than is_array Drop Resource type declaration License field refactor Additional false handling Modified unit test
davegreenwp
force-pushed
the
fix/45-unxpected-return-value-current-method
branch
from
86cc1a6 to
2b69182
Compare
|
@davegreenwp - I see what you are aiming to accomplish with this PR, however, returning I suspect that the problem that is being experienced lies within the order of operations that happen in the plugin and the moment that the license field is being output. If the collection is returning |
|
No longer required as #49 is the correct fix for the underlying issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #45
This PR refactors any instance of
get_pluginto handle the fact that this could return boolean false, thanks to interference from 3rd party plugins. Unit tests have been updated to cater for the possible false return value.These changes only deal with the problem as it presents, the exact source of the problem is still unclear, and I'm waiting for a customer to provide access to a staging site so that I can identify the plugin causing the problem on production.