Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional domain to pass along with the callback #39

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Add optional domain to pass along with the callback #39

merged 4 commits into from
Nov 14, 2023

Conversation

defunctl
Copy link
Contributor

@defunctl defunctl commented Nov 10, 2023 •
edited
Loading

This allows a user to pass an optional license domain, which is attached to the callback_url, e.g.

https://www.kadencewp.com/account-auth/?uplink_callback=https%3A%2F%2Fuplinksample.lndo.site%2Fwp%2Fwp-admin%2Fedit.php%3Fpost_type%3Dpage%26amp%3Buplink_domain%3Dtest.com%26amp%3B_uplink_nonce%3DTEy3sw9jqYlZRXk4

decoded:

https://www.kadencewp.com/account-auth/?uplink_callback=https://uplinksample.lndo.site/wp/wp-admin/edit.php?post_type=page&uplink_domain=test.com&_uplink_nonce=TEy3sw9jqYlZRXk4

Companion PR: https://github.com/stellarwp/uplink-origin/pull/48

@defunctl defunctl self-assigned this Nov 10, 2023
@defunctl defunctl marked this pull request as ready for review November 10, 2023 23:53
borkweb
borkweb requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@borkweb borkweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the formatting in one spot (we tab in once, we don't align arrows)

src/Uplink/functions.php Outdated Show resolved Hide resolved
@defunctl defunctl merged commit eef8106 into main Nov 14, 2023
4 checks passed
@defunctl defunctl deleted the feature/add-domain-to-uplink-button branch November 14, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkweb borkweb borkweb approved these changes

@kadencewp kadencewp Awaiting requested review from kadencewp

Assignees

@defunctl defunctl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@defunctl @borkweb