Skip to content

CI check: wp-browser 4.7.2 icon fix (no source change) - #194

Closed
jonwaldstein wants to merge 2 commits into
mainfrom
chore/require-wp-browser-4-7-2
Closed

CI check: wp-browser 4.7.2 icon fix (no source change)#194
jonwaldstein wants to merge 2 commits into
mainfrom
chore/require-wp-browser-4-7-2

Conversation

@jonwaldstein

@jonwaldstein jonwaldstein commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Branch content is now identical to main — this exists only to run CI and confirm the WordPress 7.1 icon-registry notices are gone now that wp-browser 4.7.2 ships _unhook_icon_registration().

The original constraint bump to >=4.7.2 was reverted: every wp-browser 4.x requires PHP ^8.0, so a floor breaks the PHP 7.4 test lane, which relies on * falling back to a 3.x release.

Will be closed once CI is green.

WordPress 7.1 registers its default icon collections and icons on `init`
and calls _doing_it_wrong() when either is registered twice, so a test
that fires `init` again trips an unexpected incorrect-usage notice.

WordPress core's test suite guards against this with
_unhook_icon_registration(). wp-browser bundles its own copy of those
core includes, and that guard landed in 4.7.2, so require at least that
version instead of working around it locally.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VMpTB259raeLKJBtGv3PBu
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: 4c2eb9c4-a533-4dcc-9fc4-b20794bc8afe

📥 Commits

Reviewing files that changed from the base of the PR and between 9092c04 and 3bad5fa.

📒 Files selected for processing (1)
  • composer.json

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The Composer development dependency constraint for lucatume/wp-browser now requires version 4.7.2 or newer instead of allowing any version.

Changes

Development dependency constraint

Layer / File(s) Summary
Update wp-browser version constraint
composer.json
The lucatume/wp-browser development dependency now requires version 4.7.2 or newer.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3bad5

This localized dependency constraint update requires wp-browser 4.7.2 or newer for the icon-registration guard; no actionable merge-blocking risk remains beyond normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the wp-browser 4.7.2 dependency update and its icon-registration fix. It also accurately notes that no source code changed.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/require-wp-browser-4-7-2

Comment @coderabbitai help to get the list of available commands.

@jonwaldstein jonwaldstein changed the title Require wp-browser 4.7.2 for the icon-registry unhook CI check: wp-browser 4.7.2 icon fix (no source change) Aug 26, 2026
@jonwaldstein

Copy link
Copy Markdown
Contributor Author

Not needed — the constraint bump broke the PHP 7.4 lane (all wp-browser 4.x requires PHP ^8.0), and * already resolves to 4.7.2 on PHP 8 lanes since composer.lock is gitignored. Nothing to merge.

@jonwaldstein
jonwaldstein deleted the chore/require-wp-browser-4-7-2 branch August 26, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant