CI check: wp-browser 4.7.2 icon fix (no source change) - #194
CI check: wp-browser 4.7.2 icon fix (no source change)#194jonwaldstein wants to merge 2 commits into
Conversation
WordPress 7.1 registers its default icon collections and icons on `init` and calls _doing_it_wrong() when either is registered twice, so a test that fires `init` again trips an unexpected incorrect-usage notice. WordPress core's test suite guards against this with _unhook_icon_registration(). wp-browser bundles its own copy of those core includes, and that guard landed in 4.7.2, so require at least that version instead of working around it locally. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VMpTB259raeLKJBtGv3PBu
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe Composer development dependency constraint for ChangesDevelopment dependency constraint
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized dependency constraint update requires wp-browser 4.7.2 or newer for the icon-registration guard; no actionable merge-blocking risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This reverts commit 3bad5fa.
|
Not needed — the constraint bump broke the PHP 7.4 lane (all wp-browser 4.x requires PHP ^8.0), and |
Branch content is now identical to
main— this exists only to run CI and confirm the WordPress 7.1 icon-registry notices are gone now that wp-browser 4.7.2 ships_unhook_icon_registration().The original constraint bump to
>=4.7.2was reverted: every wp-browser 4.x requires PHP^8.0, so a floor breaks the PHP 7.4 test lane, which relies on*falling back to a 3.x release.Will be closed once CI is green.