Skip to content

Conversation

@quietbits
Copy link
Contributor

@quietbits quietbits commented Oct 13, 2025

Example: b01bb450a2e34c95bad30ad4ad99b9682f3653c9449c2adeb267af899d5668d3 (Mainnet)

image

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Oct 13, 2025
@quietbits quietbits marked this pull request as draft October 13, 2025 15:33
@quietbits quietbits linked an issue Oct 13, 2025 that may be closed by this pull request
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@quietbits quietbits marked this pull request as ready for review November 12, 2025 16:49
@quietbits quietbits requested a review from jeesunikim November 12, 2025 16:50
@janewang
Copy link
Contributor

janewang commented Nov 12, 2025

@minkyeongshin Do you think we are fully using the horizontal space. We truncate the contract address ABCD...EFGH for consistency but I wonder if we should show this data here in full?

cc @quietbits Let us know your thoughts as well.

@janewang
Copy link
Contributor

Screenshot 2025-11-12 at 11 57 35 AM

@minkyeongshin Does the JSON have highlighting?

@quietbits
Copy link
Contributor Author

@minkyeongshin Do you think we are fully using the horizontal space. We truncate the contract address ABCD...EFGH for consistency but I wonder if we should show this data here in full?

cc @quietbits Let us know your thoughts as well.

@janewang , either is fine with me. The only drawback to showing the full contract ID is that we can't shorten it dynamically, so we'll need to wrap it. The current badge component doesn't look great with multiline text. But we can fix that.

image image

@quietbits
Copy link
Contributor Author

Screenshot 2025-11-12 at 11 57 35 AM @minkyeongshin Does the JSON have highlighting?

@janewang, the current design doesn't have JSON styled, but we can make it pretty if we want that.

@janewang
Copy link
Contributor

The only drawback to showing the full contract ID is that we can't shorten it dynamically
Let's leave them as is then, thank you!

@stellar-jenkins
Copy link

@quietbits quietbits merged commit 67df3fa into main Nov 13, 2025
7 checks passed
@quietbits quietbits deleted the tx-dash-events branch November 13, 2025 21:46
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Transaction Dashboard: Events tab

5 participants