Add dApp stellar_signAuthEntry by leofelix077 · Pull Request #743 · stellar/freighter-mobile

leofelix077 · 2026-03-03T21:46:37Z

Closes #717
Closes #742

Screen.Recording.2026-03-06.at.14.16.55.mov

Screen.Recording.2026-03-06.at.14.18.09.mov

Checklist

PR structure

This PR does not mix refactoring changes with feature changes (break it down into smaller PRs if not).
This PR has reasonably narrow scope (break it down into smaller PRs if not).
This PR includes relevant before and after screenshots/videos highlighting these changes.
I took the time to review my own PR.

Testing

These changes have been tested and confirmed to work as intended on Android.
These changes have been tested and confirmed to work as intended on iOS.
These changes have been tested and confirmed to work as intended on small iOS screens.
These changes have been tested and confirmed to work as intended on small Android screens.
I have tried to break these changes while extensively testing them.
This PR adds tests for the new functionality or fixes.

Release

This is not a breaking change.
This PR updates existing JSDocs when applicable.
This PR adds JSDocs to new functionalities.
I've checked with the product team if we should add metrics to these changes.
I've shared relevant before and after screenshots/videos highlighting these changes with the design team and they've approved the changes.

Copilot

Pull request overview

Adds initial support for WalletConnect stellar_signAuthEntry (Soroban authorization entry signing) across the mobile app, including signing logic, UI display, analytics, and E2E/mock-dApp tooling to exercise the flow.

Changes:

Implement Soroban auth entry signing (signAuthEntry) and wire it into WalletConnect request approval flow.
Update WalletConnect request UI to display auth entry XDR, add i18n strings, and add analytics tracking for successful auth entry signing.
Add mock-dApp endpoint/client support and E2E flow + CI/workflow updates to run WalletConnect mock-dApp tests.

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/services/analytics/transactions.ts	Adds `trackSignedAuthEntry` analytics tracker.
src/services/analytics/index.ts	Exposes `trackSignedAuthEntry` via `analytics` instance/interface.
src/config/analyticsConfig.ts	Adds `SIGN_AUTH_ENTRY_SUCCESS` event constant.
src/ducks/walletKit.ts	Adds `SIGN_AUTH_ENTRY` RPC method + params type.
src/helpers/stellar.ts	Implements `signAuthEntry` helper that signs `SorobanAuthorizationEntry`.
src/hooks/useGetActiveAccount.ts	Exposes `signAuthEntry` bound to the active account key.
src/helpers/walletKitUtil.ts	Handles `stellar_signAuthEntry` in `approveSessionRequest` (validation, signing, response, toast, analytics).
src/providers/WalletKitProvider.tsx	Treats `sign_auth_entry` as non-transaction request; adds E2E-only origin-check bypass; wires `signAuthEntry` into request approval.
src/components/screens/WalletKit/DappRequestBottomSheetContent.tsx	Updates request UI to support auth entry requests (title + content rendering).
src/components/screens/WalletKit/AuthEntryDisplay.tsx	New component to render raw auth entry XDR in a scrollable view.
src/i18n/locales/en/translations.json	Adds `common.authEntry` + WalletKit/dApp request strings for sign-auth-entry.
src/i18n/locales/pt/translations.json	Adds Portuguese equivalents for new sign-auth-entry strings.
src/components/WalletConnectE2EHelper.tsx	Adds UI/actions to request `signAuthEntry` from the mock-dApp server.
scripts/run-e2e-tests.sh	Adds env plumbing + on-the-fly generation for `E2E_TEST_SOROBAN_AUTH_ENTRY_XDR`; broadens mock-dApp flow detection.
e2e/flows/walletconnect/SignAuthEntryMockDapp.yaml	New Maestro flow covering the happy-path sign-auth-entry WalletConnect flow.
mock-dapp/src/walletconnect.ts	Adds mock-dApp WalletConnect client method + namespace support for `stellar_signAuthEntry`.
mock-dapp/src/routes.ts	Adds HTTP route to trigger `stellar_signAuthEntry` requests.
mock-dapp/package-lock.json	Updates lockfile for added dependency.
tests/helpers/stellar.test.ts	Adds unit tests validating `signAuthEntry` output and signature correctness.
tests/components/screens/SendScreen/screens/TransactionAmountScreen.test.tsx	Updates mocks for `useGetActiveAccount` to include `signAuthEntry`.
tests/components/screens/SendScreen/screens/SendCollectibleReview.test.tsx	Updates mocks for `useGetActiveAccount` to include `signAuthEntry`.
.github/workflows/ios-e2e.yml	Enables mock-dApp WalletConnect flows (SignMessage + SignAuthEntry) in matrix.
.github/workflows/android-e2e.yml	Enables mock-dApp WalletConnect flows (SignMessage + SignAuthEntry) in matrix.

Files not reviewed (1)

mock-dapp/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

socket-security · 2026-03-05T16:02:29Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@stellar/stellar-base@14.1.0
	npm/express-rate-limit@7.5.1

View full report

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 49 out of 51 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

mock-dapp/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…can site for blockaid

Copilot

Pull request overview

Copilot reviewed 49 out of 51 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

mock-dapp/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…r-mobile into lf-dapp-sign-auth-entry

CassioMG · 2026-03-18T22:57:04Z

   * @function handleCancelSecurityWarning
   * @returns {void}
   */
-  const handleCancelSecurityWarning = useCallback(() => {


@leofelix077 is this useCallback function wrapping removal intentional?

Copilot

Pull request overview

Copilot reviewed 51 out of 53 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

mock-dapp/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

add v1 of sign auth entries

45614ec

leofelix077 self-assigned this Mar 3, 2026

Copilot AI review requested due to automatic review settings March 3, 2026 21:46

leofelix077 added wip work in progress don't review yet Work in Progress / Draft PR / Code Review adjustments being worked on labels Mar 3, 2026

Copilot started reviewing on behalf of leofelix077 March 3, 2026 21:47 View session

github-advanced-security AI found potential problems Mar 3, 2026

View reviewed changes

Comment thread mock-dapp/src/routes.ts Fixed

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread src/providers/WalletKitProvider.tsx Outdated

leofelix077 added 8 commits March 4, 2026 12:08

add logs for mockdapp server startup

0f0da4e

add ui for sign auth entries on mock-dapp and xdr error handling

77528dd

refactor network seleciton

7926bdb

update e2e press button on wc paste

65c6eff

update e2e press button on wc paste

8d51ba2

allow cleartext traffic on e2e tests

df9cd62

allow cleartext traffic on e2e tests

bc2310c

fix auth entry generation

8391495

leofelix077 added 5 commits March 5, 2026 13:36

fix pid fetch for android e2e

00adb7f

fix pid fetch for android e2e

9b1af0a

retrigger e2e flow

7815d1e

restore full e2e tests on CI

29facb9

adjust rate limiting for api endpoint

acb37cd

leofelix077 requested a review from Copilot March 5, 2026 19:31

Copilot AI reviewed Mar 5, 2026

View reviewed changes

refactor sign auth entries into sub components

ce0761d

leofelix077 changed the title ~~[WIP] add v1 of sign auth entries~~ Add dApp stellar_signAuthEntry Mar 6, 2026

leofelix077 added 4 commits March 6, 2026 14:47

adjust max height for scrollable xdr

1561169

adjust max height for scrollable xdr

972aef4

revert e2e tests into isolated files

0e2ba50

update dapp auth entry button id

33a0a20

Copilot started reviewing on behalf of leofelix077 March 17, 2026 22:58 View session

Merge branch 'main' into lf-dapp-sign-auth-entry

33dd834

Copilot AI reviewed Mar 17, 2026

View reviewed changes

Comment thread src/components/screens/WalletKit/DappAuthEntryDisplay.tsx Outdated

Comment thread src/components/screens/WalletKit/DappAuthEntryDetails.tsx Outdated

Comment thread src/providers/WalletKitProvider.tsx

Comment thread src/hooks/useGetActiveAccount.ts

leofelix077 added 3 commits March 17, 2026 21:20

adjust translation keys and constants from copilot review

6fe8adb

update logic to sign hash pre image instead of sorobanauthentry and s…

a3b4316

…can site for blockaid

remove double blockaid scan from signAuthEntry

a83f4a5

leofelix077 requested a review from Copilot March 18, 2026 16:36

Copilot started reviewing on behalf of leofelix077 March 18, 2026 16:36 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

Comment thread src/helpers/walletKitUtil.ts

Comment thread docs/walletconnect-rpc-methods.md Outdated

Comment thread src/helpers/walletKitUtil.ts

Comment thread src/components/screens/WalletKit/DappRequestBottomSheetContent.tsx

leofelix077 and others added 6 commits March 18, 2026 15:16

Potential fix for pull request finding

44057e0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix message matching for rejection on dapp sign request

1104299

Merge branch 'lf-dapp-sign-auth-entry' of github.com:stellar/freighte…

4b16908

…r-mobile into lf-dapp-sign-auth-entry

clear error message from queue and display toast to user

930d9b4

adjust error messages for empty or malformed xdr and auth entry

b91272a

add auth entry XDR pre validation

2925e34

CassioMG reviewed Mar 18, 2026

View reviewed changes

CassioMG approved these changes Mar 18, 2026

View reviewed changes

leofelix077 added 4 commits March 19, 2026 15:16

add more prevalidations for sign auth entry network

5f3884b

add network mismatch e2e test

c97e0e7

add network mismatch e2e test

fc42521

remove network mismatch e2e test

388cace

leofelix077 requested a review from Copilot March 19, 2026 19:17

Copilot started reviewing on behalf of leofelix077 March 19, 2026 19:18 View session

Merge branch 'main' into lf-dapp-sign-auth-entry

762747d

Copilot AI reviewed Mar 19, 2026

View reviewed changes

Comment thread docs/walletconnect-rpc-methods.md Outdated

Comment thread src/providers/WalletKitProvider.tsx Outdated

Comment thread src/providers/WalletKitProvider.tsx Outdated

Comment thread src/providers/WalletKitProvider.tsx Outdated

Comment thread src/helpers/walletKitValidation.ts

leofelix077 added 2 commits March 19, 2026 16:38

remove unsafe access and update docs

c149ded

merge main into branch

85c8319

leofelix077 merged commit 273148c into main Mar 19, 2026
27 checks passed

leofelix077 deleted the lf-dapp-sign-auth-entry branch March 19, 2026 20:08

github-actions Bot mentioned this pull request Mar 19, 2026

v1.13.25 #776

Merged

Conversation

leofelix077 commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

PR structure

Testing

Release

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

socket-security Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CassioMG Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leofelix077 commented Mar 3, 2026 •

edited

Loading

socket-security Bot commented Mar 5, 2026 •

edited

Loading