Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pyproject.toml #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate to pyproject.toml #62

wants to merge 1 commit into from

Conversation

cunla
Copy link
Contributor

@cunla cunla commented Jul 23, 2024 •
edited
Loading

  • Migrate to pyproject.toml
    • Using poetry.
    • Defining all project settings in the TOML file.
      • Included package, script, etc. (no need for MANIFEST.in)
      • Dependencies (no need for requirements-dev.txt)
      • Classifiers (no need for setup.py)
      • Authors, maintainers, versions (no need for AUTHORS, setup.cfg)
  • Run black formatter on code files
  • Update GitHub workflow to support new structure.

@cunla
Copy link
Contributor Author

cunla commented Aug 3, 2024

@stefankoegl, you have been unresponsive on emails.
Any update on this?

Should we open a PIP541 ticket?

@stefankoegl
Copy link
Owner

Hi! I have blocked some time on Monday to look into this.

Btw, on GitHub mobile it currently shows this PR as unable to merge (I don't see any details, though)

@cunla
Copy link
Contributor Author

cunla commented Aug 3, 2024

I can't see any merge conflicts here - not sure.
Happy to discuss.

stefankoegl
stefankoegl reviewed Aug 5, 2024
View reviewed changes
Copy link
Owner

@stefankoegl stefankoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As I am not familiar with poetry, would you mind documenting (or referencing documentation) for basics such as updating dependencies?

@cunla
Copy link
Contributor Author

cunla commented Aug 6, 2024

I'll address this further once added to the pypi package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefankoegl stefankoegl stefankoegl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cunla @stefankoegl