Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Gym to Gymnasium #30

Merged
merged 15 commits into from
Apr 28, 2023
Merged

Switch from Gym to Gymnasium #30

merged 15 commits into from
Apr 28, 2023

Conversation

stefanbschneider
Copy link
Owner

@stefanbschneider stefanbschneider commented Apr 25, 2023 •
edited
Loading

Close #26

Additional changes unrelated to gymnasium:

  • Update dependencies and remove unnecessary version pins
  • Change to style format black and add pre-commit hooks
  • Add some basic test for each registered env

@stefanbschneider
Fix setup
63c765d 
Fix python_requires and add pandas.
Increment gym

TODO: Fix gym issues, update to Gymnasium
@stefanbschneider
Add small test notebook
b11f64d
@stefanbschneider
Switch from gym to gymnasium
34caea4 
- reset() API was changed to accept extra args and return obs and info
- step() API was changed to return terminated and truncated instead of done
- render API was changed to set the render_mode during init not render()

Notebooks still have to be updated
@stefanbschneider
Correctly define supported render modes
570d6f3
@stefanbschneider
Start updating notebooks
6a0e746 
- test notebook is done
- demo notebook is still WIP
@stefanbschneider stefanbschneider added the dependencies Pull requests that update a dependency file label Apr 25, 2023
@stefanbschneider stefanbschneider self-assigned this Apr 25, 2023
@stefanbschneider
Copy link
Owner Author

Update of demo notebook still WIP.

@stefanbschneider
Fix: Initialize seeds on demand
a5bfe2e
@stefanbschneider
Drop all version pins and increment mobile-env version
1cc93cf 
For better compatibility and to fix the CI
Increment to mobile-env 2.0.0 due to breaking API change with new gymnasium API
@stefanbschneider
Use alpha version of sb3 for testing
d33f82d 
For gymnasium support. Will be in sb3 v2.0
@stefanbschneider
Pin setuptools to v65.5.0
03674a7 
To install gym v0.21 without errors
@stefanbschneider
Update test requirements
b53957d 
ray and sb3 need conflicting versions of gym
disable ray for now
@stefanbschneider
Fix demo notebook
268f687
@stefanbschneider
Add simple tests for all envs
712fc53 
That just run until done with random actions.
@stefanbschneider
Change to code style black and add pre-commit hooks
3ad9557
@stefanbschneider
Fix: Undo renamed consturctor arg
47905a9 
Was unintentionally renamed earlier
@stefanbschneider
limit importlib to avoid flake8 error
cba6b0b 
https://stackoverflow.com/a/73932581/2745116
@stefanbschneider stefanbschneider marked this pull request as ready for review April 28, 2023 17:17
@stefanbschneider stefanbschneider changed the title Gym to gymnasium Switch from Gym to Gymnasium Apr 28, 2023
@stefanbschneider stefanbschneider merged commit b0eab32 into main Apr 28, 2023
6 checks passed
@stefanbschneider stefanbschneider deleted the gym-to-gymnasium branch April 28, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stefanbschneider stefanbschneider

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: migrate from gym to gymnasium
1 participant
@stefanbschneider