Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Roots #5

Merged
merged 22 commits into from
Mar 15, 2025
Merged

Validate Roots #5

merged 22 commits into from
Mar 15, 2025

Conversation

yulesa
Copy link
Contributor

@yulesa yulesa commented Feb 19, 2025

No description provided.

@yulesa yulesa changed the title Validate hashes Validate Roots Feb 21, 2025
@yulesa
Copy link
Contributor Author

yulesa commented Feb 26, 2025

Any data error should not stop the program from running. Instead, if it finds a data issue, it should print the error in a report or to std_output and continue with the execution of the validation. This way, you can surface multiple mistakes all at once and work on their fix.
For that, we need to review any unwrap or except, but it should be done in another PR.
This is important if you run the validation functions in stored data, not streamed data.

Copy link
Member

@ozgrakkurt ozgrakkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪

@ozgrakkurt ozgrakkurt marked this pull request as ready for review March 15, 2025 04:34
@ozgrakkurt ozgrakkurt merged commit 6e58ed7 into steelcake:main Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants