Skip to content

Conversation

@Neerajpathak07
Copy link
Member

@Neerajpathak07 Neerajpathak07 commented Jan 2, 2026

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds number/float16/base/assert/is-almost-equal

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@Neerajpathak07 Neerajpathak07 changed the title feat: add number/float16/base/assert/is-same-equal feat: add number/float16/base/assert/is-almost-equal Jan 2, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 2, 2026

Coverage Report

Package Statements Branches Functions Lines
number/float16/base/assert/is-almost-equal $\color{green}132/132$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}132/132$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 2, 2026 12:46
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 2, 2026
@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Jan 2, 2026

@gururaj1512 like you suggested have added the package itself will add the other files like assert/benchmark etc once this lands in!!

@Neerajpathak07 Neerajpathak07 added the Feature Issue or pull request for adding a new feature. label Jan 3, 2026
@Neerajpathak07
Copy link
Member Author

@kgryte can we land this in so after which we can have the assert folder to add the utility number/float16/base/assert/is-negative-zero

Planeshifter
Planeshifter previously approved these changes Jan 7, 2026
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 7, 2026
Signed-off-by: Philipp Burckhardt <[email protected]>
@stdlib-js stdlib-js deleted a comment from stdlib-bot Jan 7, 2026
@Planeshifter Planeshifter removed the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `number/float16/base/assert/is-almost-equal`

PR-URL: https://github.com/stdlib-js/stdlib/pull/9500

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 5301fb5 into stdlib-js:develop Jan 7, 2026
31 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026
@Neerajpathak07 Neerajpathak07 deleted the add-is-almost-equal branch January 8, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants