feat: add `array/float16` #7435

udaykakade25 · 2025-06-21T07:41:43Z

progresses #7347 and #7273

Description

What is the purpose of this pull request?

This pull request:

Adds array/float16 folder

Related Issues

Does this pull request have any related issues?

This pull request:

resolves feat: add assert/is-float16array #7273 feat: add assert/has-float16array-support #7347

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This is the third PR. First two PRs are interconnected to each other. In order to merge this PR, we need to first merge PR 1: #7273 and #7347

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

udaykakade25 · 2025-06-21T07:43:02Z

/stdlib update-copyright-years

udaykakade25 · 2025-06-21T07:52:47Z

Hello @Planeshifter and @kgryte sir,
With this PR, i have completed array/float16.
Please do review and merge PR along with two previously mentioned PRs.

So, i can start working on adding float16 datatype support for array/base, array/*, strided/8 and ndarray/*

kgryte · 2025-06-21T22:56:48Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+
+// MAIN //
+
+class Float16Array {


This entire implementation should be refactored. We do not use ES6+. All code must be written in ES5. Furthermore, all methods and properties should be documented. See array/bool and array/complex128 for what we expect.

kgryte · 2025-06-21T22:58:15Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+		return Float16Array.fromFloat16(this._buffer[index]);
+	}
+
+  get buffer() {


This file also does not conform to our style conventions and includes mixed tabs and spaces. Please follow our development guide and ensure that your local environment is properly setup. Our automated linting and EditorConfig configuration would have flagged all these issues.

kgryte · 2025-06-21T22:58:45Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+	const offset = value !== undefined ? Number(value) : 0;
+
+	if (offset < 0 || offset > this.length) {
+		throw new RangeError('Offset is out of bounds');


This is not how we format error messages.

kgryte · 2025-06-21T22:59:10Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+		(ArrayBuffer.isView(source) && typeof source.length === 'number') ||
+		(source instanceof Float16Array))
+	) {
+		const len = Math.min(source.length, this.length - offset);


We do not use Math built-ins. Everything should be implemented in terms of stdlib functionality.

kgryte · 2025-06-21T22:59:48Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+	return this._entriesGenerator();
+}
+
+*_entriesGenerator() {


entries should be implemented using iterators directly. Use of generators is not allowed in ES5.

kgryte

@udaykakade25 Thank you for working on this. I left a few initial comments. The TL;DR is that the entire implementation needs to be reworked to be implemented in ES5. I strongly encourage you to emulate the style and approach used in array/bool and other custom array types implemented in stdlib.

Signed-off-by: Uday Kakade <[email protected]>

udaykakade25 · 2025-06-29T06:19:58Z

@udaykakade25 Thank you for working on this. I left a few initial comments. The TL;DR is that the entire implementation needs to be reworked to be implemented in ES5. I strongly encourage you to emulate the style and approach used in array/bool and other custom array types implemented in stdlib.

Hello @kgryte sir, I have refactored the whole polyfill.js file that follows stdlib style. Thanks for reviewing!!

kgryte · 2025-06-29T07:09:04Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+* @throws {TypeError} Must provide valid input
+*/
+function Float16Array( input, byteOffset, length ) {
+    var i;


This file should be all TAB indentation. Currently, you are using space indentation.

kgryte · 2025-06-29T07:09:40Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+    if ( typeof input === 'number' ) {
+        this._buffer = new Uint16Array( input );
+    } else if ( input instanceof ArrayBuffer ) {
+        offset = byteOffset >>> 0;


This isn't correct. >>> 0 casts byteOffset to uint32, but typed arrays can have more than 2**32 - 1 elements.

kgryte · 2025-06-29T07:10:36Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+* @readonly
+* @type {ArrayBuffer}
+*/
+Object.defineProperty( Float16Array.prototype, 'buffer', {


As in array/bool, you should be using our utilities for defining properties. E.g., utils/define-nonenumerable-read-only-accessor. Right now, buffer is enumerable, which it shouldn't be.

kgryte · 2025-06-29T07:11:22Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+*/
+Float16Array.from = function( source, mapFn, thisArg ) {
+    if ( source == null ) {
+        throw new TypeError( 'invalid argument. Source cannot be null or undefined. Value: `' + source + '`.' );


For error formatting, as in array/bool, you should be using @stdlib/string/format.

kgryte · 2025-06-29T07:13:09Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+    var result = new Float16Array( this.length );
+    var i;
+    var val;
+    if ( typeof callback !== 'function' ) {


You need to be using stdlib assertion utilities for validation here and everywhere else. E.g., assert/is-function.

kgryte · 2025-06-29T07:14:07Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+* @param {*} [thisArg] - Context
+* @returns {boolean} Whether all pass
+*/
+Float16Array.prototype.every = function( callback, thisArg ) {


Please define methods in alphabetical order. This makes searching for a particular easier for future readers of this code.

kgryte · 2025-06-29T07:15:06Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+*
+* @returns {Object} Iterator
+*/
+Float16Array.prototype.keys = function() {


We don't use anonymous functions. We used named functions to assist in making stack traces more legible.

kgryte · 2025-06-29T07:15:55Z

lib/node_modules/@stdlib/array/float16/lib/polyfill.js

+
+    this.length = this._buffer.length;
+}
+


You are missing static constructor properties, such the constructor name and BYTES_PER_ELEMENT.

kgryte · 2025-06-29T07:18:03Z

Also, for this PR to move forward, CI should be passing. Currently, CI is failing on linting, benchmarks, examples, and tests.

Signed-off-by: Uday Kakade <[email protected]>

udaykakade25 · 2025-06-29T20:14:28Z

Also, for this PR to move forward, CI should be passing. Currently, CI is failing on linting, benchmarks, examples, and tests.

Hello @kgryte sir,
I have changes that follow the standards below
TABS Indentation ✅
Alphabetical Order ✅
Offset >>> 0 fix ✅
Readonly added ✅
Error formatting ✅
Utilities Added ✅
No Anonymous functions ✅
Missing Statistics Added ✅

Regarding failed CI checks:
Just Linting errors in Readme.md and Repl.txt are remaining to fix.
Rest other issues are encountered because the assert\has-float16array-support #7347 and assert/is-float16array #7273 PRs is still pending.

feat: add array/float16

4e48d21

stdlib-bot added the Needs Review A pull request which needs code review. label Jun 21, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 21, 2025

chore: update copyright years

8c52f25

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 21, 2025

kgryte reviewed Jun 21, 2025

View reviewed changes

kgryte requested changes Jun 21, 2025

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 21, 2025

stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Jun 22, 2025

Refactored Polyfill.js

8611f89

Signed-off-by: Uday Kakade <[email protected]>

kgryte reviewed Jun 29, 2025

View reviewed changes

Refactored polyfill.js

12e4814

Signed-off-by: Uday Kakade <[email protected]>

Uh oh!

feat: add array/float16 #7435

Are you sure you want to change the base?

feat: add array/float16 #7435

Conversation

udaykakade25 commented Jun 21, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

udaykakade25 commented Jun 21, 2025

Uh oh!

udaykakade25 commented Jun 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

udaykakade25 commented Jun 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte commented Jun 29, 2025

Uh oh!

udaykakade25 commented Jun 29, 2025

Uh oh!

Uh oh!

feat: add `array/float16` #7435

feat: add `array/float16` #7435