-
-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for number/float32/base/signbit
#3399
base: develop
Are you sure you want to change the base?
Conversation
@Planeshifter I just added all the essential files and building the logic but I am still facing issues with the gyp native addons. |
Check out the workflow failures. E.g., the lint step of
tells us that several needed fields are not set and should be added. |
@Planeshifter I have added the essential files in the dependency tree of package.json.
|
Coverage Report
The above coverage report was generated for the changes in this PR. |
@Planeshifter All CI checks are passing pls review it. I am going to need this for implementing |
@Neerajpathak07 Wil try taking a look and review tonight. |
lib/node_modules/@stdlib/number/float32/base/signbit/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/number/float32/base/signbit/manifest.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this!
Looks pretty good to me. manifest.json
will need some updates. @kgryte, you mind taking final look please and then merge the PR after the comments have been addressed?
@Planeshifter Thank you for the review. |
@kgryte any suggestions from your side?? |
Resolves #3397
Description
This pull request:
number/float32/base/signbit
Related Issues
This pull request:
number/float32/base/signbit
#3397 & [RFC]: Add C implementations to base special math functions (tracking issue) #649Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers