Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/dirac-deltaf #3363

Merged
merged 6 commits into from
Jan 9, 2025
Merged

feat: add math/base/special/dirac-deltaf #3363

merged 6 commits into from
Jan 9, 2025

Conversation

aayush0325
Copy link
Member

@aayush0325 aayush0325 commented Dec 7, 2024 •
edited by gunjjoshi
Loading

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

  • adds math/base/special/dirac-deltaf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 7, 2024
@aayush0325
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 7, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/dirac-deltaf $\color{green}160/160$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}160/160$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter
Planeshifter approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending update of copyright year.

@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 9, 2025
@stdlib-bot
Copy link
Contributor

@Planeshifter, slash command not recognized. Please use /stdlib help to view available commands.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 9, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 9, 2025
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 9, 2025
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 9, 2025
@aayush0325
Copy link
Member Author

resolved linting error

@Planeshifter Planeshifter merged commit ff48331 into stdlib-js:develop Jan 9, 2025
28 checks passed
@aayush0325 aayush0325 deleted the dirac-deltaf branch January 9, 2025 13:55
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 9, 2025
@aayush0325 @saurabhraghuvanshii
feat: add math/base/special/dirac-deltaf
c369d83 
PR-URL: stdlib-js#3363
Ref: stdlib-js#649

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 9, 2025
@aayush0325 @saurabhraghuvanshii
feat: add math/base/special/dirac-deltaf
f70805d 
PR-URL: stdlib-js#3363
Ref: stdlib-js#649

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@aayush0325 @stdlib-bot @0PrashantYadav0
feat: add math/base/special/dirac-deltaf
df36844 
PR-URL: stdlib-js#3363
Ref: stdlib-js#649

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayush0325 @stdlib-bot @Planeshifter