feat: add C implementation for math/base/special/bernoulli
#1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Since there was inactivity on #1664 due to a dependency's C implementation not being done, and all its dependencies' C installation are done now, so I've made this PR. |
Pranavchiku
reviewed
Mar 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/lib/native.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <[email protected]>
Pranavchiku
suggested changes
Mar 13, 2024
Member
Pranavchiku
left a comment
Pranavchiku
left a comment
There was a problem hiding this comment.
Minor changes requested, once done this will be ready to merge.
Pranavchiku
added
Feature
Co-authored-by: Pranav <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]>
Co-authored-by: Pranav <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Member
Author
|
I have made the changes as per your suggestions. Thanks for pointing them out @Pranavchiku ! |
Pranavchiku
reviewed
Mar 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <[email protected]>
Pranavchiku
approved these changes
Mar 13, 2024
Member
Pranavchiku
left a comment
Pranavchiku
left a comment
There was a problem hiding this comment.
Works well locally. Looks good to me. Thanks @gunjjoshi !
Pranavchiku
added
Ready To Merge
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1664
Description
This pull request:
math/base/special/bernoulli.Related Issues
This pull request:
@stdlib/math/base/special/bernoulli#1664Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers