Skip to content

chore: fix JavaScript lint errors - #13967

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
ashudhanda:fix-js-lint-11147
Aug 6, 2026
Merged

chore: fix JavaScript lint errors#13967
kgryte merged 2 commits into
stdlib-js:developfrom
ashudhanda:fix-js-lint-11147

Conversation

@ashudhanda

Copy link
Copy Markdown
Contributor

Resolves #11147.

Description

What is the purpose of this pull request?

This pull request:

  • fixes 5 stdlib/no-unnecessary-nested-functions lint errors in lib/node_modules/@stdlib/_tools/scripts/transform.js by moving the onStringFormat, dropFirst, deleteComment, rewriteRequire, and hasRequire helper functions to module scope (a new FUNCTIONS section), as they do not depend on any closure variables. The assignFormatVar and onStringLiteral functions are intentionally left nested, as they rely on variables scoped to transformer.
  • fixes 2 no-multi-spaces lint errors in lib/node_modules/@stdlib/_tools/github/org-repos/lib/validate.js by collapsing the extra spaces in the format calls for the token and useragent options.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • While making these changes, I noticed a pre-existing typo in transform.js: ERROR_NAMES.indexof (lowercase o) in the second NewExpression branch of onStringLiteral. It is left unchanged here, as it is outside the scope of this lint fix, but I am happy to open a separate issue/PR for it.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by an AI assistant, which verified the reported lint errors against develop, analyzed the closure dependencies of the nested functions, and generated the changes. I reviewed the diff before submission.


@stdlib-js/reviewers

@ashudhanda
ashudhanda requested a review from a team August 6, 2026 06:23
@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Aug 6, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Aug 6, 2026
Comment thread lib/node_modules/@stdlib/_tools/scripts/transform.js Outdated
Comment thread lib/node_modules/@stdlib/_tools/scripts/transform.js Outdated
Comment thread lib/node_modules/@stdlib/_tools/scripts/transform.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Aug 6, 2026
@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #11147) chore: fix JavaScript lint errors Aug 6, 2026
@kgryte
kgryte merged commit 6ca1a04 into stdlib-js:develop Aug 6, 2026
44 checks passed
@kgryte

kgryte commented Aug 6, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution and congratulations on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 5 Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants