chore: fix JavaScript lint errors - #13967
Merged
Merged
Conversation
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
kgryte
reviewed
Aug 6, 2026
kgryte
reviewed
Aug 6, 2026
kgryte
reviewed
Aug 6, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
Member
|
Thank you for your contribution and congratulations on your first PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11147.
Description
This pull request:
stdlib/no-unnecessary-nested-functionslint errors inlib/node_modules/@stdlib/_tools/scripts/transform.jsby moving theonStringFormat,dropFirst,deleteComment,rewriteRequire, andhasRequirehelper functions to module scope (a newFUNCTIONSsection), as they do not depend on any closure variables. TheassignFormatVarandonStringLiteralfunctions are intentionally left nested, as they rely on variables scoped totransformer.no-multi-spaceslint errors inlib/node_modules/@stdlib/_tools/github/org-repos/lib/validate.jsby collapsing the extra spaces in theformatcalls for thetokenanduseragentoptions.Related Issues
This pull request has the following related issues:
Questions
No.
Other
transform.js:ERROR_NAMES.indexof(lowercaseo) in the secondNewExpressionbranch ofonStringLiteral. It is left unchanged here, as it is outside the scope of this lint fix, but I am happy to open a separate issue/PR for it.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by an AI assistant, which verified the reported lint errors against
develop, analyzed the closure dependencies of the nested functions, and generated the changes. I reviewed the diff before submission.@stdlib-js/reviewers